Skip to content

feat: Add upgrade() functions to L1 upgradeable contracts#13471

Closed
maurelian wants to merge 115 commits intodevelopfrom
upgrade-funcs-4
Closed

feat: Add upgrade() functions to L1 upgradeable contracts#13471
maurelian wants to merge 115 commits intodevelopfrom
upgrade-funcs-4

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

@maurelian maurelian commented Dec 18, 2024

All proxied L1 contracts should have the following changes:

  1. Added an upgrade() function with empty body to the contract.
  2. Added the function to the interface
  3. Added happy and sad path test cases to verify the upgrade functionality. New tests are written in a way that conforms with the style of the test file.

Upgrade has no constructor
- Implemented the ability to use interop in test configurations.
- Added checks to skip tests when certain conditions for forked tests are met.
- Enhanced Setup with options for overriding L2 genesis and creating forks.
- Included additional logging for L1 setup processes.
- Enabled etching of deployed upgrade contracts for testing purposes.
@maurelian maurelian force-pushed the upgrade-against-registry-3 branch from 80887d9 to 9f44651 Compare December 19, 2024 03:17
maurelian and others added 2 commits December 18, 2024 22:25
Base automatically changed from upgrade-against-registry-3 to upgrade-against-registry December 19, 2024 03:42
@maurelian maurelian requested review from a team as code owners December 19, 2024 03:56
@maurelian maurelian requested review from mslipper and removed request for a team December 19, 2024 03:56
Base automatically changed from upgrade-against-registry to develop December 19, 2024 14:19
@circleci-checks circleci-checks bot requested a review from a team as a code owner December 19, 2024 14:19
@maurelian maurelian marked this pull request as draft December 19, 2024 15:01
@maurelian maurelian closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant