chore: solidity isthmus to interop#12132
Merged
protolambda merged 4 commits intoethereum-optimism:developfrom Sep 26, 2024
Merged
chore: solidity isthmus to interop#12132protolambda merged 4 commits intoethereum-optimism:developfrom
protolambda merged 4 commits intoethereum-optimism:developfrom
Conversation
This was referenced Sep 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12132 +/- ##
========================================
Coverage 74.94% 74.94%
========================================
Files 49 49
Lines 3652 3652
========================================
Hits 2737 2737
Misses 743 743
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
protolambda
reviewed
Sep 25, 2024
Contributor
protolambda
left a comment
There was a problem hiding this comment.
Hmm, why are tests passing, when the OP Contracts Manager implementations deployer contract has not been updated?
tynes
approved these changes
Sep 26, 2024
protolambda
approved these changes
Sep 26, 2024
Contributor
|
Github complains about a merge conflict, but local merge with |
protolambda
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename
L1BlockIsthmustoL1BlockInteropfor consistency with the upgrade naming.The scope of it is only the Solidity files, there will be another one with the changes on the Golang files because that's how it was asked from reviewers.
Tests
I added no tests, but only modified the contracts name so they don' break
Additional context
PR with the Golang files renaming changes: #12133