Skip to content

Add log downloading for sync integration tests #1095

Closed
#1098
Closed
Add log downloading for sync integration tests#1095
#1098
@smartcontracts

Description

@smartcontracts
smartcontracts
opened on Jun 15, 2021

Is your feature request related to a problem? Please describe.
Seems like we've recently added sync tests to our integration tests: https://github.com/ethereum-optimism/optimism/blob/develop/.github/workflows/sync-tests.yml. However, the sync tests do not upload the logs as artifacts to GitHub like the integration tests do. This makes it very difficult to debug the tests.

Describe the solution you'd like
I'd like to see these lines added to the sync tests:

optimism/.github/workflows/integration.yml

Lines 97 to 113 in c87e4c7

- name: Collect docker logs on failure
if: failure()
uses: jwalton/gh-docker-logs@v1
with:
images: 'ethereumoptimism/builder,ethereumoptimism/hardhat,ethereumoptimism/deployer,ethereumoptimism/data-transport-layer,ethereumoptimism/l2geth,ethereumoptimism/message-relayer,ethereumoptimism/batch-submitter,ethereumoptimism/l2geth,ethereumoptimism/integration-tests'
dest: './logs'
- name: Tar logs
if: failure()
run: tar cvzf ./logs.tgz ./logs
- name: Upload logs to GitHub
if: failure()
uses: actions/upload-artifact@master
with:
name: logs.tgz
path: ./logs.tgz

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions