feat(cmn): hard stop on multiple exit signals (#2378)

smartcontracts · mergify[bot] · web-flow · commit e36b085ca64c · 2022-03-31T20:25:40.000Z
Adds a new feature to BaseServiceV2 to have a service exit immediately
when 3 exit signals are received. Useful when the main loop would take a
long time to exit but you want the service to exit immediately.

Co-authored-by: mergify[bot] &lt;37929162+mergify[bot]@users.noreply.github.com&gt;
diff --git a/.changeset/fair-cows-think.md b/.changeset/fair-cows-think.md
@@ -0,0 +1,5 @@
+---
+'@eth-optimism/common-ts': patch
+---
+
+Adds hard stop to BaseServiceV2 when multiple exit signals are received
diff --git a/packages/common-ts/src/base-service/base-service-v2.ts b/packages/common-ts/src/base-service/base-service-v2.ts
@@ -247,11 +247,26 @@ export abstract class BaseServiceV2<
     this.logger = new Logger({ name: params.name })
 
     // Gracefully handle stop signals.
+    const maxSignalCount = 3
+    let currSignalCount = 0
     const stop = async (signal: string) => {
-      this.logger.info(`stopping service with signal`, { signal })
-      await this.stop()
-      process.exit(0)
+      // Allow exiting fast if more signals are received.
+      currSignalCount++
+      if (currSignalCount === 1) {
+        this.logger.info(`stopping service with signal`, { signal })
+        await this.stop()
+        process.exit(0)
+      } else if (currSignalCount >= maxSignalCount) {
+        this.logger.info(`performing hard stop`)
+        process.exit(0)
+      } else {
+        this.logger.info(
+          `send ${maxSignalCount - currSignalCount} more signal(s) to hard stop`
+        )
+      }
     }
+
+    // Handle stop signals.
     process.on('SIGTERM', stop)
     process.on('SIGINT', stop)
   }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@eth-optimism/common-ts': patch
 +---
++
 +Adds hard stop to BaseServiceV2 when multiple exit signals are received