feat: add Isthmus BLS precompiles#472
Closed
meyer9 wants to merge 1 commit intoethereum-optimism:optimismfrom
Closed
feat: add Isthmus BLS precompiles#472meyer9 wants to merge 1 commit intoethereum-optimism:optimismfrom
meyer9 wants to merge 1 commit intoethereum-optimism:optimismfrom
Conversation
This was referenced Jan 23, 2025
Contributor
|
You can rebase this now that #471 has been merged |
b7041d3 to
1b2933e
Compare
Make sure g1 add implemented
1b2933e to
12e8db8
Compare
tynes
approved these changes
Feb 3, 2025
Contributor
|
We still need to add in the input size restrictions |
refcell
approved these changes
Feb 4, 2025
Contributor
flagging @meyer9 |
Contributor
Author
|
Added here - will rebase once this is merged: #490 |
Contributor
|
@meyer9 https://github.com/ethereum-optimism/op-geth/pull/490/files seems to implement this. Is this PR still needed? I'm cutting op-geth releases so we can use these precompiles in the op-program and I'd like to know if there's any remaining code that needs to be merged? |
Contributor
Author
|
hmm yeah that one was supposed to be based on this one, so this is technically already merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds precompiles for BLS operations as specified in EIP-2537.
Depends on #471 (and has changes from this since I can't change the base of the PR)