Skip to content
This repository was archived by the owner on Apr 11, 2021. It is now read-only.

tests: Add Synthetix test suite#69

Open
smartcontracts wants to merge 3 commits intomasterfrom
tests/synthetix
Open

tests: Add Synthetix test suite#69
smartcontracts wants to merge 3 commits intomasterfrom
tests/synthetix

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description
Dead simple method of adding the Synthetix L2 test suite into our integration tests. Won't be particularly fast but that's not a huge priority right now. We should be able to speed this up later on.

Additional context
We've been wanting this for a while, would be nice to have this even if it's a bit jank.

@smartcontracts smartcontracts requested a review from tynes as a code owner March 23, 2021 04:47
@smartcontracts
Copy link
Copy Markdown
Contributor Author

@tynes looks like it's trying to run publish inside of the test-synthetix folder instead of test-synthetix/synthetix. It should cd synthetix before running node publish deploy-ovm-pair. Any clue why this is bugging out?

integration_tests_1     |  | Error: Cannot find module '/integration-tests/packages/test-synthetix/publish'
integration_tests_1     |  |     at Function.Module._resolveFilename (packages/test-synthetix/internal/modules/cjs/loader.js:880:15)
integration_tests_1     |  |     at Function.Module._load (packages/test-synthetix/internal/modules/cjs/loader.js:725:27)
integration_tests_1     |  |     at Function.executeUserEntryPoint [as runMain] (packages/test-synthetix/internal/modules/run_main.js:72:12)
integration_tests_1     |  |     at packages/test-synthetix/internal/main/run_main_module.js:17:47 {
integration_tests_1     |  |   code: 'MODULE_NOT_FOUND',
integration_tests_1     |  |   requireStack: []
integration_tests_1     |  | }

@smartcontracts
Copy link
Copy Markdown
Contributor Author

Works fine locally but maybe I just did something wrong

@smartcontracts
Copy link
Copy Markdown
Contributor Author

:-/ adds a full hour to our integration test time

@K-Ho
Copy link
Copy Markdown

K-Ho commented Mar 29, 2021

:-/ adds a full hour to our integration test time

Any thoughts on speeding up the integration tests here @snario? I think this is very high priority to get in to prevent regressions. Just looked at the Synthetix CI and looks like it spends ~12 min running the same tests, so I feel like we can get pretty far by just beefing up CI

@snario
Copy link
Copy Markdown
Contributor

snario commented Mar 29, 2021

:-/ adds a full hour to our integration test time

Any thoughts on speeding up the integration tests here @snario? I think this is very high priority to get in to prevent regressions. Just looked at the Synthetix CI and looks like it spends ~12 min running the same tests, so I feel like we can get pretty far by just beefing up CI

Seems like in the very near term the best we can do is make this run once a day and ask developers to try running it once locally if making a substantial change to the codebase. In the medium term we should figure out which tests are included here that we can rip out and put into our own testing infrastructure in a way that tests very specific functionality.

There are also some other kinds of CI improvements we should consider focusing some attention on, maybe next week, like more caching and less duplication of work between jobs and test suites.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants