Gate pre-fork requests on max uint256 excess inhibitor#26
Merged
lightclient merged 2 commits intomainfrom Oct 1, 2024
Merged
Conversation
mkalinin
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h/t @mkalinin for the alternative idea to #23
--
Instead of gating pre-fork requests via the computed fee, Mikhail had the idea that we can just revert if during the calculation we find the current excess value to be
0xff..ff. It's a much smaller amount of overhead versus using a separate storage slot to signal the fork has passed, but also avoid the possibility of retriggering the reset condition post-fork.