Add inhibitor to queue before activation#12
Merged
lightclient merged 3 commits intomainfrom Apr 22, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a features first requested by @marioevz.
The concern is that before 7002 becomes active, it would be possible to join the queue without
excessgrowing. This means the queue could be filled extremely cheaply.To avoid this, we set the value of
excessto an extremely high value so that no user could ever pay a fee to enter the queue. This avoids additionalsloadsduring normal operations.We chose
1181as the value ofexcessbecause i) it a prime and ii)fake_exponential(1, 1181, 17) = 1481455745989958413761130954915 weiwhich is more than 1 trillion eth. That's more eth than will (hopefully) ever exist.Each system call will check
excess == 1181and use0in it's place if so. This of course will only be true for the first call following activation of Prague.