Create Meeting 08.md#235
Merged
timbeiko merged 3 commits intoethereum:masterfrom Jan 4, 2021
Avishek041180:master
Merged
Conversation
Review and merge
timbeiko
reviewed
Dec 21, 2020
Contributor
There was a problem hiding this comment.
Looks good, @Avishek041180, only a few small fixes.
Fee Market Meetings/Meeting 08.md
Outdated
|
|
||
| **Tim Beiko**: Okay next up Abdel do you want to give a quick update on the large state testnet generator and where we are at? | ||
|
|
||
| **Abdulhamid Bakhta**: Okay, yes so we currently have set up the new testnet so, this will be a |
Contributor
There was a problem hiding this comment.
Suggested change
| **Abdulhamid Bakhta**: Okay, yes so we currently have set up the new testnet so, this will be a | |
| **Abdelhamid Bakhta**: Okay, yes so we currently have set up the new testnet so, this will be a |
Can you please update throughout? Thanks!
Contributor
Author
There was a problem hiding this comment.
Thanks for review .
I have updated the notes with your suggestions.
Fee Market Meetings/Meeting 08.md
Outdated
|
|
||
| **Tim Beiko**: No worries. Any thoughts or comments on the testnet. | ||
|
|
||
| **Nethermid**: I think it would be important to make sure that every single node is publishing transactions of their own. Respective transaction pools so we know that we can not only consume the transaction load but also that every single one can generate them. |
Contributor
There was a problem hiding this comment.
Suggested change
| **Nethermid**: I think it would be important to make sure that every single node is publishing transactions of their own. Respective transaction pools so we know that we can not only consume the transaction load but also that every single one can generate them. | |
| **Nethermind**: I think it would be important to make sure that every single node is publishing transactions of their own. Respective transaction pools so we know that we can not only consume the transaction load but also that every single one can generate them. |
Can you please update throuhgout? Thanks!
Contributor
Author
There was a problem hiding this comment.
Thanks for review .
I have updated the notes with your suggestions.
Co-authored-by: Tim Beiko <t.beiko23@gmail.com>
Fixed typo error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review and merge