docs(CONTRIBUTING.md): Add Contributing instructions#17476
Merged
fjl merged 2 commits intoethereum:masterfrom Sep 25, 2018
Merged
docs(CONTRIBUTING.md): Add Contributing instructions#17476fjl merged 2 commits intoethereum:masterfrom
fjl merged 2 commits intoethereum:masterfrom
Conversation
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
Contributor
Author
|
Let me know if the 80-character issue needs to be adhered to for docs. Happy to change it. |
ef9b3fb to
09be5b3
Compare
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
The contributing instructions in the README are not in the GitHub contributing guide, which means that people coming from the GitHub issues are less likely to see them. By copying those instructions here, we are more likely to have less errors like not using gofmt and so on. Another option would be removing the section from the README, and pointing users to the Contribute guide there, to stop duplication. But I am not sure this is entirely necessary.
09be5b3 to
3a83f71
Compare
Contributor
Author
|
I should add a note to the Contribute file to make sure to wrap your lines in your commit messages to 80 characters. I'd be happy to add that to this PR, or in another subsequent one if that's easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contributing instructions in the README are not in the GitHub contributing guide, which means that people coming from the GitHub issues are less likely to see them. By copying those instructions here, we are more likely to have less errors like not using gofmt and so on. Another option would be removing the section from the README, and pointing users to the Contribute guide there, to stop duplication. But I am not sure this is entirely necessary.