feat(consume): send slot_number in build-block payload attributes#2974
Merged
marioevz merged 1 commit intoJun 10, 2026
Merged
Conversation
marioevz
approved these changes
Jun 10, 2026
marioevz
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for catching this!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2974 +/- ##
================================================
Coverage 90.53% 90.53%
================================================
Files 535 535
Lines 32893 32893
Branches 3021 3021
================================================
Hits 29780 29780
Misses 2595 2595
Partials 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_payload_attributes()never setsslot_number, so the build-block simulator always sends slot 0 totesting_buildBlockV1. Blocks whose expected slot is non-zero can't be built, and SLOTNUM (EIP-7843) only ever gets exercised returning 0.The expected payload already has the slot, so just forward it. The field is already on
PayloadAttributes(optional, serializes asslotNumber), so no other changes needed.Noticed while running build-block against ethrex on the Amsterdam BAL fixtures.