refactor(spec-specs): remove unused regular gas constants in amsterdam#2971
Merged
spencer-tb merged 1 commit intoJun 10, 2026
Merged
Conversation
EIP-8037 moved the new-account, storage-set, selfdestruct new-account and per-empty-authorization charges to state gas (`StateGasCosts`), leaving their legacy regular-gas counterparts unreferenced: - `GasCosts.STORAGE_SET` (20000) - `GasCosts.NEW_ACCOUNT` (25000) - `GasCosts.AUTH_PER_EMPTY_ACCOUNT` (25000) - `GasCosts.OPCODE_SELFDESTRUCT_NEW_ACCOUNT` (25000) Remove them to avoid confusion with the state-gas values now in use.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2971 +/- ##
===================================================
- Coverage 90.53% 90.52% -0.01%
===================================================
Files 535 535
Lines 32897 32893 -4
Branches 3021 3021
===================================================
- Hits 29782 29778 -4
Misses 2596 2596
Partials 519 519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Draft
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Removes four regular gas constants from
forks/amsterdamthat became unreferenced when EIP-8037 (#2901) moved the corresponding charges to state gas (StateGasCosts):GasCosts.STORAGE_SET(20000): SSTORE set-from-zero now chargesStateGasCosts.STORAGE_SET.GasCosts.NEW_ACCOUNT(25000):CALL*/SELFDESTRUCT/creation account charges now useStateGasCosts.NEW_ACCOUNT.GasCosts.AUTH_PER_EMPTY_ACCOUNT(25000): Per-authorization costs are now split intoPER_AUTH_BASE_COST(regular) andStateGasCosts.NEW_ACCOUNT + StateGasCosts.AUTH_BASE(state).GasCosts.OPCODE_SELFDESTRUCT_NEW_ACCOUNT(25000): Folded into the state-gas charge above.Pure dead-code removal with no behavior change. Verified each constant has no remaining references within
forks/amsterdam; earlier forks keep their own copies per the WET principle.🔗 Related Issues or PRs
Follow-up to #2901.
✅ Checklist
just statictype(scope):.Cute Animal Picture