chore(tests): remove duplicate tstore tests#2966
Merged
marioevz merged 1 commit intoJun 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2966 +/- ##
================================================
Coverage 90.50% 90.50%
================================================
Files 535 535
Lines 32700 32700
Branches 3011 3011
================================================
Hits 29595 29595
Misses 2588 2588
Partials 517 517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Remove
test_run_until_out_of_gasundertests/cancun/eip1153_tstore/test_tstorage.py, since its parametrization s are similar to the existing benchmark tests:LoopRunUntilOutOfGasCases.TSTORE: Repeatststoreuntil OOG, distinct key and value pair => same astest_tstore (fixed_key = False, fixed_value = False)andtest_tstore_unique_keysLoopRunUntilOutOfGasCases.TSTORE_WIDE_ADDRESS_SPACE: Repeatststoreuntil OOG, distinct key-value pair, with wider address space => similar totest_tstore (fixed_key = False, fixed_value = False)andtest_tstore_unique_keys, not sure if we need wider space scenario, as there is no storage trie for transient storage.LoopRunUntilOutOfGasCases.TSTORE_TLOAD: Runtstoreandtloadin loop until out of gas => similar totest_tstore_unique_keys (with with_tload = True)One more reason to remove
test_run_until_out_of_gasis, the test only runs one single transaction, while benchmark tests would exhaust the block gas limit and try to pack as much tx as possible.🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture