Skip to content

chore(tests): remove duplicate tstore tests#2966

Merged
marioevz merged 1 commit into
ethereum:forks/amsterdamfrom
LouisTsai-Csie:add-tstore-benchmark
Jun 9, 2026
Merged

chore(tests): remove duplicate tstore tests#2966
marioevz merged 1 commit into
ethereum:forks/amsterdamfrom
LouisTsai-Csie:add-tstore-benchmark

Conversation

@LouisTsai-Csie

@LouisTsai-Csie LouisTsai-Csie commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

🗒️ Description

Remove test_run_until_out_of_gas under tests/cancun/eip1153_tstore/test_tstorage.py, since its parametrization s are similar to the existing benchmark tests:

  • LoopRunUntilOutOfGasCases.TSTORE: Repeats tstore until OOG, distinct key and value pair => same as test_tstore (fixed_key = False, fixed_value = False) and test_tstore_unique_keys
  • LoopRunUntilOutOfGasCases.TSTORE_WIDE_ADDRESS_SPACE: Repeats tstore until OOG, distinct key-value pair, with wider address space => similar to test_tstore (fixed_key = False, fixed_value = False) and test_tstore_unique_keys, not sure if we need wider space scenario, as there is no storage trie for transient storage.
  • LoopRunUntilOutOfGasCases.TSTORE_TLOAD: Run tstore and tload in loop until out of gas => similar to test_tstore_unique_keys (with with_tload = True)

One more reason to remove test_run_until_out_of_gas is, the test only runs one single transaction, while benchmark tests would exhaust the block gas limit and try to pack as much tx as possible.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@LouisTsai-Csie LouisTsai-Csie self-assigned this Jun 9, 2026
@LouisTsai-Csie LouisTsai-Csie added C-chore Category: chore A-tests Area: Consensus tests. labels Jun 9, 2026
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (9c2813e) to head (83eaa18).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2966   +/-   ##
================================================
  Coverage            90.50%   90.50%           
================================================
  Files                  535      535           
  Lines                32700    32700           
  Branches              3011     3011           
================================================
  Hits                 29595    29595           
  Misses                2588     2588           
  Partials               517      517           
Flag Coverage Δ
unittests 90.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marioevz marioevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 21ecd8f into ethereum:forks/amsterdam Jun 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants