Skip to content

feat(tests): add EIP-8024 gas boundary and SWAPN invalid-immediate tests#2942

Merged
felix314159 merged 1 commit into
ethereum:forks/amsterdamfrom
chfast:tests/eip8024-gas-boundary-swapn-sweep
Jun 1, 2026
Merged

feat(tests): add EIP-8024 gas boundary and SWAPN invalid-immediate tests#2942
felix314159 merged 1 commit into
ethereum:forks/amsterdamfrom
chfast:tests/eip8024-gas-boundary-swapn-sweep

Conversation

@chfast

@chfast chfast commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🗒️ Description

Add more EIP-8024 SWAPN/DUPN/EXCHANGE coverage.

🔗 Related Issues or PRs

#2726

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (abf6ff6) to head (b32ac7b).

Additional details and impacted files 
@@               Coverage Diff                @@
##           forks/amsterdam    #2942   +/-   ##
================================================
  Coverage            90.49%   90.49%           
================================================
  Files                  535      535           
  Lines                32430    32430           
  Branches              3012     3012           
================================================
  Hits                 29349    29349           
  Misses                2563     2563           
  Partials               518      518
Flag Coverage Δ
unittests 90.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

LouisTsai-Csie
LouisTsai-Csie approved these changes Jun 1, 2026
View reviewed changes

@LouisTsai-Csie LouisTsai-Csie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felix314159
felix314159 approved these changes Jun 1, 2026
View reviewed changes

@felix314159 felix314159 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please rebase so that we can get it merged

@chfast chfast force-pushed the tests/eip8024-gas-boundary-swapn-sweep branch from c2bd6f8 to b32ac7b Compare June 1, 2026 13:06
@felix314159 felix314159 merged commit d7def91 into ethereum:forks/amsterdam Jun 1, 2026
18 checks passed
@spencer-tb spencer-tb mentioned this pull request Jun 2, 2026
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felix314159 felix314159 felix314159 approved these changes

@LouisTsai-Csie LouisTsai-Csie LouisTsai-Csie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chfast @felix314159 @LouisTsai-Csie