fix(test-tests): Add fork name to cached blob filename to prevent xdist flakes#2930
Merged
danceratopz merged 2 commits intoJun 2, 2026
Merged
Conversation
…st race condition
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2930 +/- ##
================================================
Coverage 90.50% 90.50%
================================================
Files 535 535
Lines 32407 32407
Branches 3011 3011
================================================
Hits 29331 29331
Misses 2559 2559
Partials 517 517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danceratopz
approved these changes
Jun 2, 2026
danceratopz
left a comment
Member
There was a problem hiding this comment.
Nice! Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
I ran into a race condition in test-tests-pypy this morning where the test calls
Blob.from_forkfor two parametrized cases running in parallel — CancunToPragueAtTime15k at ts=14999 (resolves to Cancun) and at ts=15000 (resolves to Prague). Both resolve to read fromblob_0_cell_proofs_0.jsonunder the old naming.If the Cancun worker ran first and wrote the file with "fork": "Cancun" stored in the JSON, the Prague worker would find the file already exists, load it, and get back a blob with fork=Cancun. The test then asserts b.fork.name() ==
"Prague" and fails.
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.[ ] Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.[ ] Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned@ported_frommarker.Cute Animal Picture