Skip to content

feat(tests): extend BAL create collision test cases#2917

Merged
spencer-tb merged 4 commits into
ethereum:forks/amsterdamfrom
fselmo:feat/extend-bal-create-collision-tests
May 28, 2026
Merged

feat(tests): extend BAL create collision test cases#2917
spencer-tb merged 4 commits into
ethereum:forks/amsterdamfrom
fselmo:feat/extend-bal-create-collision-tests

Conversation

@fselmo

@fselmo fselmo commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🗒️ Description

🔗 Related Issues or PRs

closes #2914

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Screenshot 2026-05-26 at 08 58 09

@fselmo fselmo requested a review from raxhvl May 26, 2026 15:08
@fselmo fselmo added C-feat Category: an improvement or new feature A-tests Area: Consensus tests. labels May 26, 2026
@fselmo fselmo mentioned this pull request May 26, 2026
Closed
@codecov

codecov Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.43%. Comparing base (4441398) to head (c157d75).

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2917      +/-   ##
===================================================
+ Coverage            87.11%   90.43%   +3.32%     
===================================================
  Files                  535      535              
  Lines                32430    32430              
  Branches              3012     3012              
===================================================
+ Hits                 28251    29329    +1078     
+ Misses                3593     2573    -1020     
+ Partials               586      528      -58
Flag Coverage Δ
unittests 90.43% <ø> (+3.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fselmo fselmo mentioned this pull request May 26, 2026
Closed
6 tasks
raxhvl
raxhvl reviewed May 26, 2026
View reviewed changes
Comment thread tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_opcodes.py Outdated
@fselmo fselmo force-pushed the feat/extend-bal-create-collision-tests branch 3 times, most recently from 032a764 to 77770cd Compare May 26, 2026 17:48
raxhvl
raxhvl reviewed May 26, 2026
View reviewed changes
Comment thread tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_opcodes.py Outdated
raxhvl
raxhvl approved these changes May 26, 2026
View reviewed changes

@raxhvl raxhvl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Good to merge.

@jangko

jangko commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Is there any test covering case like: collision, then account get deleted in the same tx. nonce become x -> 0, code hash x -> EMPTY_CODEHASH?

Don't know what will happen with the storage in that situation.

Don't mind it, it's not related to collision.

spencer-tb
spencer-tb approved these changes May 28, 2026
View reviewed changes

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@spencer-tb spencer-tb force-pushed the feat/extend-bal-create-collision-tests branch from e460702 to c157d75 Compare May 28, 2026 12:24
@spencer-tb

spencer-tb commented May 28, 2026

Copy link
Copy Markdown
Contributor

First time rebasing manually...
Screenshot 2026-05-28 at 13 23 29

@spencer-tb spencer-tb merged commit efd53ff into ethereum:forks/amsterdam May 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

+1 more reviewer

@raxhvl raxhvl raxhvl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@raxhvl raxhvl

Labels

A-tests Area: Consensus tests. C-feat Category: an improvement or new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing BAL test cases of contract creation collision edge cases

4 participants

@fselmo @jangko @spencer-tb @raxhvl