feat(tests): Extend coverage for BAL#2897
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2897 +/- ##
================================================
Coverage 90.44% 90.44%
================================================
Files 535 535
Lines 32439 32439
Branches 3012 3012
================================================
Hits 29338 29338
Misses 2573 2573
Partials 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
fselmo
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
lgtm! I added some parametrization to the BAL gas limit boundary test that adds a tx or withdrawal (so has a variant also with both). I believe this is what the ask was for case 3 here and it helps us test this boundary a bit more thoroughly.
Can you look over this last commit and give a final thumbs up and we can merge? @raxhvl
Member
Author
|
All okay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds additional coverage to BAL. h/t @holgerd77 for these suggestions!
CREATEhas been extended to includeCREATE2.✅ Checklist
just statictype(scope):.