feat(tests): EIP-8037 CREATE-tx collision refunds state-gas reservoir#2875
Merged
spencer-tb merged 1 commit intoJun 10, 2026
Conversation
6 tasks
marioevz
previously approved these changes
Jun 9, 2026
marioevz
left a comment
Member
There was a problem hiding this comment.
LGTM, just one comment. Also we need to rebase and merge to forks/amsterdam
Add `test_create_tx_collision_refunds_reservoir`: a depth-0 CREATE-tx with `gas_limit > TX_MAX_GAS_LIMIT` that collides at the deterministic CREATE address. The existing collision test uses `gas_limit` near the intrinsic, so the state-gas reservoir is empty and the reservoir-preservation path is untested. Block-level `gas_used` is the same under both buggy and correct behaviors; the sender's post-balance is the discriminator. A buggy implementation that drops the reservoir on collision overcharges the sender by `reservoir * gas_price`.
84686b2 to
235e5a1
Compare
spencer-tb
approved these changes
Jun 10, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
LGTM! @marioevz's comments are addressed.
Contributor
|
Closed/reopened to trigger CI. It hit a race cond. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2875 +/- ##
===================================================
- Coverage 90.53% 90.52% -0.01%
===================================================
Files 535 535
Lines 32897 32893 -4
Branches 3021 3021
===================================================
- Hits 29782 29778 -4
Misses 2596 2596
Partials 519 519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add
test_create_tx_collision_refunds_reservoir: a depth-0 CREATE-tx withgas_limit > TX_MAX_GAS_LIMITthat collides at the deterministic CREATE address. The existing collision test usesgas_limitnear the intrinsic, so the state-gas reservoir is empty and the reservoir-preservation path is untested.Block-level
gas_usedis the same under both buggy and correct behaviors; the sender's post-balance is the discriminator. A buggy implementation that drops the reservoir on collision overcharges the sender byreservoir * gas_price.🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture