feat(tests): EIP-7778 multi-tx mixed gas regimes block accounting#2871
Merged
LouisTsai-Csie merged 1 commit intoMay 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2871 +/- ##
===================================================
+ Coverage 87.14% 87.16% +0.01%
===================================================
Files 586 586
Lines 35792 35792
Branches 3364 3364
===================================================
+ Hits 31192 31199 +7
+ Misses 3950 3943 -7
Partials 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
approved these changes
May 19, 2026
LouisTsai-Csie
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Leave some comments but not blocking merging the PR.
| ) | ||
|
|
||
|
|
||
| @pytest.mark.execute(pytest.mark.skip(reason="Requires specific gas price")) |
Collaborator
Member
Author
There was a problem hiding this comment.
I copied this from sibling tests.
Add `test_3tx_mixed_gas_regimes` exercising the EIP-7778 identity `block.gas_used == sum_i max(pre_refund_i, floor_i)` across a block where each tx hits a different regime: tx1: SSTORE-set fresh slot (no refund, pre_refund > floor) tx2: SSTORE-clear x10 (normal refund, refund not clipped to floor) tx3: 1000 zero-byte calldata to STOP (floor binds upward) Per-tx sender balances are also asserted so the floor-binding tx locks in `floor * gas_price` (not `pre_refund * gas_price`), the multi-tx accumulator bug EIP-7778 prevents. The 2-tx `test_multi_transaction_gas_accounting` never combines a refund- bearing tx with a floor-binding tx in the same block.
f538cd1 to
3dcebc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add
test_3tx_mixed_gas_regimesexercising the EIP-7778 identityblock.gas_used == sum_i max(pre_refund_i, floor_i)across a block where each tx hits a different regime:tx1: SSTORE-set fresh slot (no refund, pre_refund > floor)
tx2: SSTORE-clear x10 (normal refund, refund not clipped to floor)
tx3: 1000 zero-byte calldata to STOP (floor binds upward)
Per-tx sender balances are also asserted so the floor-binding tx locks in
floor * gas_price(notpre_refund * gas_price), the multi-tx accumulator bug EIP-7778 prevents. The 2-txtest_multi_transaction_gas_accountingnever combines a refund- bearing tx with a floor-binding tx in the same block.🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture