Skip to content

fix(tests): drop gas_price from EIP-7702 txs in BAL 7702 tests#2862

Merged
fselmo merged 2 commits into
ethereum:forks/amsterdamfrom
chfast:fix-tests-bal-7702-gas-price
May 15, 2026
Merged

fix(tests): drop gas_price from EIP-7702 txs in BAL 7702 tests#2862
fselmo merged 2 commits into
ethereum:forks/amsterdamfrom
chfast:fix-tests-bal-7702-gas-price

Conversation

@chfast

@chfast chfast commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🗒️ Description

EIP-7702 (type-4) transactions don't have a gas_price field; remove the stray gas_price=0xA from txs that include an authorization_list.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

🐛

@chfast
fix(tests): drop gas_price from EIP-7702 txs in BAL 7702 tests
94a7996 
EIP-7702 (type-4) transactions don't have a gas_price field; remove
the stray gas_price=0xA from txs that include an authorization_list.
@codecov

codecov Bot commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.14%. Comparing base (78a79ee) to head (6d0e6ef).

Additional details and impacted files 
@@               Coverage Diff                @@
##           forks/amsterdam    #2862   +/-   ##
================================================
  Coverage            87.14%   87.14%           
================================================
  Files                  586      586           
  Lines                35792    35792           
  Branches              3364     3364           
================================================
  Hits                 31192    31192           
  Misses                3950     3950           
  Partials               650      650
Flag Coverage Δ
unittests 87.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fselmo
fselmo approved these changes May 15, 2026
View reviewed changes

@fselmo fselmo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chfast 👍🏼. I also added a validation to prevent this from silently happening again.

@chfast

chfast commented May 15, 2026

Copy link
Copy Markdown
Member Author

Thanks @chfast 👍🏼. I also added a validation to prevent this from silently happening again.

I was to suggest this. Very nice.

@fselmo fselmo merged commit ff14345 into ethereum:forks/amsterdam May 15, 2026
21 checks passed
@edg-l edg-l mentioned this pull request May 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fselmo fselmo fselmo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chfast @fselmo