Skip to content

feat(tests): EIP-7843 Add test cases for multi-blocks and fork transition#2858

Merged
LouisTsai-Csie merged 3 commits into
ethereum:forks/amsterdamfrom
kclowes:feat/7843-addl-test-cases
May 19, 2026
Merged

feat(tests): EIP-7843 Add test cases for multi-blocks and fork transition#2858
LouisTsai-Csie merged 3 commits into
ethereum:forks/amsterdamfrom
kclowes:feat/7843-addl-test-cases

Conversation

@kclowes

@kclowes kclowes commented May 14, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

Adds test cases for 7843 SLOTNUM for fork transition, and across multiple blocks.

🔗 Related Issues or PRs

Closes #2856

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes added C-feat Category: an improvement or new feature A-test-tests Area: tests for packages/testing labels May 14, 2026
@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.16%. Comparing base (b3f5df5) to head (16872ec).
⚠️ Report is 6 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2858      +/-   ##
===================================================
+ Coverage            86.94%   87.16%   +0.22%     
===================================================
  Files                  586      586              
  Lines                35777    35792      +15     
  Branches              3363     3364       +1     
===================================================
+ Hits                 31106    31199      +93     
+ Misses                4012     3943      -69     
+ Partials               659      650       -9     
Flag Coverage Δ
unittests 87.16% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kclowes kclowes force-pushed the feat/7843-addl-test-cases branch from 68ce735 to bd22e08 Compare May 15, 2026 17:18
@kclowes kclowes marked this pull request as ready for review May 15, 2026 17:18
@kclowes kclowes requested review from marioevz and spencer-tb May 15, 2026 17:18

@LouisTsai-Csie LouisTsai-Csie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave some of my idea in the comment! Thanks

Comment thread tests/amsterdam/eip7843_slotnum/test_eip_mainnet.py
Comment thread tests/amsterdam/eip7843_slotnum/test_eip_mainnet.py Outdated
Comment thread tests/amsterdam/eip7843_slotnum/test_fork_transition.py

@marioevz marioevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, lgtm, thanks!

@LouisTsai-Csie LouisTsai-Csie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, not a blocker!

Comment thread tests/amsterdam/eip7843_slotnum/test_eip_mainnet.py Outdated
Comment thread tests/amsterdam/eip7843_slotnum/test_eip_mainnet.py
@LouisTsai-Csie LouisTsai-Csie merged commit 8732abe into ethereum:forks/amsterdam May 19, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tests Area: tests for packages/testing C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EIP- 7843 additional test cases

3 participants