🧪 feat(tests): EIP-7928 BAL test for 7702 account call with low balance#2824
Conversation
|
@raxhvl can you run |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2824 +/- ##
================================================
Coverage 88.62% 88.62%
================================================
Files 577 577
Lines 35659 35659
Branches 3490 3490
================================================
Hits 31604 31604
Misses 3492 3492
Partials 563 563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… to test_cases.md
…d, CALL & CALLCODE
fselmo
left a comment
There was a problem hiding this comment.
@raxhvl thanks for this! I made two additions, specifically in two separate commits here so we can track it:
-
first commit: I added some parametrization across warm/cold target and delegation which doesn't change anything but good to add I think. We also don't need the
bal=1. Can do with / without changing that but the non-empty code (delegation designation) is enough for the account to not be empty. -
second commit: I actually looked to add CALLCODE case as well and then thought to parametrize it all. I think it reads clean but lmk what you think... adds extra coverage here.
Also added the test to test_cases.md. Approving but lmk what your final review on my pushes are and we can merge or edit before merging 👀
🗒️ Description
Adds coverage for BAL tests targeting 7702 accounts. Checks if authority and delegate are recorded when called into with insufficient call value.
✅ Checklist
just statictype(scope):.