feat(test-fill): add --post-verifications flag to capture fill time post state checks#2552
Merged
spencer-tb merged 1 commit intoMar 25, 2026
Merged
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2552 +/- ##
================================================
Coverage 86.35% 86.35%
================================================
Files 599 599
Lines 36904 36904
Branches 3771 3771
================================================
Hits 31868 31868
Misses 4485 4485
Partials 551 551
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Found and fixed a bug in the static test parser that removed the non-existing account checks in commit 5ae5824. |
marioevz
approved these changes
Mar 24, 2026
marioevz
left a comment
Member
There was a problem hiding this comment.
Awesome, I think we should refill the static tests to get the new baseline with this new added information that we have to make sure to preserve in the ported tests.
I left only two suggestions.
Member
|
Great idea!! This is really useful for what I am doing, thanks ❤️ |
leolara
approved these changes
Mar 25, 2026
5adb56c to
a4c6167
Compare
…hecks Add a PostVerifications Pydantic model that records exactly which post-state checks are performed during a fill session. When `--post-verifications` is passed, a `postVerifications` field is included in the fixture JSON output, capturing which account fields (nonce, balance, code, storage) are verified and their expected values. This enables diffing verification coverage between two fill runs via `hasher compare` to detect silently lost assertions.
a4c6167 to
d0f1ae1
Compare
--post-verifier flag to capture fill time post state checks--post-verifications flag to capture fill time post state checks
Contributor
Author
|
Renamed all to |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds a PostVerifications Pydantic model that records exactly which post-state checks are performed during a fill session. When
--post-verificationsis passed, apostVerificationsfield is included in the fixture JSON output, capturing which account fields (nonce, balance, code, storage) are verified and their expected values. This enables diffing verification coverage between two fill runs viahasher compareto detect silently lost assertions.This is added to help aid with #2514, so that we can check where we lose post state verification checks from the static test ports to python.
Note when running fill with
--post-verificationsthe new field is included within the info hash calculation for the fixture.We might want not even merge this given its redundant in the future.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture