Skip to content

chore(do not merge): small memory optimizations for spec tools + specs#2368

Closed
kevaundray wants to merge 12 commits into
ethereum:forks/amsterdamfrom
kevaundray:kw/small-opt-memory
Closed

chore(do not merge): small memory optimizations for spec tools + specs#2368
kevaundray wants to merge 12 commits into
ethereum:forks/amsterdamfrom
kevaundray:kw/small-opt-memory

Conversation

@kevaundray

@kevaundray kevaundray commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kevaundray kevaundray force-pushed the kw/small-opt-memory branch from fe3a89e to d8ff39c Compare March 1, 2026 03:03
@kevaundray kevaundray force-pushed the kw/small-opt-memory branch from d8ff39c to 337b4a4 Compare March 1, 2026 03:03
@codecov

codecov Bot commented Mar 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.19298% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.94%. Comparing base (47ae746) to head (a466fd9).

Files with missing lines Patch % Lines
src/ethereum/crypto/hash.py 33.33% 2 Missing ⚠️
...vm/precompiled_contracts/bls12_381/bls12_381_g1.py 91.66% 2 Missing ⚠️
...vm/precompiled_contracts/bls12_381/bls12_381_g1.py 91.66% 2 Missing ⚠️
...vm/precompiled_contracts/bls12_381/bls12_381_g1.py 91.66% 2 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2368      +/-   ##
===================================================
+ Coverage            84.89%   84.94%   +0.05%     
===================================================
  Files                  599      600       +1     
  Lines                36719    36532     -187     
  Branches              3780     3724      -56     
===================================================
- Hits                 31172    31032     -140     
+ Misses                4916     4895      -21     
+ Partials               631      605      -26
Flag Coverage Δ
unittests 84.94% <97.19%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevaundray kevaundray force-pushed the kw/small-opt-memory branch from f01bc10 to 5d00530 Compare March 1, 2026 16:20
@kevaundray kevaundray changed the title chore(do not merge): small memory optimizations for spec tools chore(do not merge): small memory optimizations for spec tools + specs Mar 1, 2026
This was referenced Mar 1, 2026
Merged
Open
Merged
Merged
@kevaundray kevaundray force-pushed the kw/small-opt-memory branch from 4ed91e9 to a466fd9 Compare March 1, 2026 23:16
@kevaundray

kevaundray commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Most of the relevant changes have been pulled out, so closing

@kevaundray kevaundray closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kevaundray