Skip to content

bug(pytest): fixed repository root getting cluttered with logs/ directory when running with tox #1632

Merged
SamWilsn merged 1 commit intoethereum:forks/osakafrom
DeborahOlaboye:fix/logs-dir
Oct 31, 2025
Merged

bug(pytest): fixed repository root getting cluttered with logs/ directory when running with tox #1632
SamWilsn merged 1 commit intoethereum:forks/osakafrom
DeborahOlaboye:fix/logs-dir

Conversation

@DeborahOlaboye
Copy link
Copy Markdown
Contributor

@DeborahOlaboye DeborahOlaboye commented Oct 17, 2025

🗒️ Description

🔗 Related Issues or PRs

Fixes #1456

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

SamWilsn
SamWilsn reviewed Oct 20, 2025
View reviewed changes
@SamWilsn SamWilsn force-pushed the fix/logs-dir branch 2 times, most recently from 57456db to d658a94 Compare October 22, 2025 16:00
SamWilsn
SamWilsn reviewed Oct 22, 2025
View reviewed changes
SamWilsn
SamWilsn approved these changes Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable enough. Just one last question.

@SamWilsn SamWilsn merged commit 9563a51 into ethereum:forks/osaka Oct 31, 2025
7 of 9 checks passed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (533299f) to head (d265baf).
⚠️ Report is 5 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##           forks/osaka    #1632   +/-   ##
============================================
  Coverage        86.07%   86.07%           
============================================
  Files              743      743           
  Lines            44078    44078           
  Branches          3894     3894           
============================================
  Hits             37938    37938           
  Misses            5659     5659           
  Partials           481      481
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SamWilsn SamWilsn mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repository root gets cluttered with logs/ directory when running with tox

3 participants

@DeborahOlaboye @codecov-commenter @SamWilsn