Remove tracing pollution from spec#1356
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1356 +/- ##
===============================================
- Coverage 94.16% 94.15% -0.01%
===============================================
Files 583 583
Lines 34680 34666 -14
Branches 3070 3070
===============================================
- Hits 32655 32641 -14
Misses 1492 1492
Partials 533 533
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
gurukamath
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issues #909 & #1351
How was it fixed?
TransactionEnvironment, after this PR we store them within the tracer object itself. This removes a bit of unnecessary and single purpose code from the specification.trace_memory,trace_stack, andtrace_return_dataarguments from theEvmTracer. Not all trace implementations need these arguments, so threading them throughethereum.traceis overly coupled.Cute Animal Picture