chore(weld): Move src/cli -> src/ethereum_test_cli#2154
Conversation
|
@danceratopz before I go further down this path, is this what we're aiming for to address ethereum/execution-specs#1402 ? |
081936e to
5e6d0f2
Compare
There was a problem hiding this comment.
Thanks for getting on this @kclowes. I think we should hold off with this and the other renamings until
is merged as it touches almost every source file and we'll have a lot of conflicts and a hard time rebasing.
If in the meantime you could take a holistic view to naming in ethereum-execution and see if it makes sense that would help. What I mean is, does the namespacing in the package make sense at all :) In particular:
- Wdyt about the path
src/ethereum_spec_tests/ethereum_test_base_typesas there's a lot of "ethereum" and "test" in those paths )) - After this change we'll have
ethereum_test_cliandethereum_clis. Is this unambiguous enough?
I think it'd be helpful to do a build of ethereum-execution in EELS and check the namespacing as it currently is to see if it makes sense.
We should also keep this renaming in mind: #2133.
Hey @kclowes! In the meantime, the mass formatting PR has been merged: as has Felix's other module renaming PR: But I think we should look at the "total package", before proceeding :) Would you be willing to pick up this up? 🙏 I think it'd be go ok to close this PR and start PRing this once we have agreement on the package layout. |
|
Yep, will close this and put up a proposal to talk about next week in #2209. Thanks! |
🗒️ Description
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.