new(tests): Add EIP-6110 Sepolia Variant Contract test#1280
Closed
marioevz wants to merge 5 commits into
Closed
Conversation
danceratopz
reviewed
Mar 5, 2025
danceratopz
left a comment
Member
There was a problem hiding this comment.
LGTM, confirmed locally via hive that these clients fail this test as expected:
- client: besu
nametag: sepolia
build_args:
baseimage: hyperledger/besu
tag: 25.2.1
- client: go-ethereum
nametag: sepolia
build_args:
baseimage: ethereum/client-go
tag: v1.15.3
- client: nethermind
nametag: sepolia
build_args:
baseimage: nethermind/nethermind
tag: 1.31.2
- client: reth
nametag: sepolia
build_args:
baseimage: ghcr.io/paradigmxyz/reth
tag: v1.2.1
Comment on lines
+98
to
+110
| return ( | ||
| b"\0" * (192) | ||
| + self.pubkey | ||
| + b"\0" * (48) | ||
| + self.withdrawal_credentials | ||
| + b"\0" * (32) | ||
| + (self.amount).to_bytes(8, byteorder="little") | ||
| + b"\0" * (56) | ||
| + self.signature | ||
| + b"\0" * (32) | ||
| + (self.index).to_bytes(8, byteorder="little") | ||
| + b"\0" * (24) | ||
| ) |
Member
There was a problem hiding this comment.
How about creating an empty bytearray and writing the relevant data where it's expected? Something like:
Suggested change
| return ( | |
| b"\0" * (192) | |
| + self.pubkey | |
| + b"\0" * (48) | |
| + self.withdrawal_credentials | |
| + b"\0" * (32) | |
| + (self.amount).to_bytes(8, byteorder="little") | |
| + b"\0" * (56) | |
| + self.signature | |
| + b"\0" * (32) | |
| + (self.index).to_bytes(8, byteorder="little") | |
| + b"\0" * (24) | |
| ) | |
| data = bytearray(..) | |
| data[192:192+48] = self.pubkey | |
| ... | |
| return bytes(data) |
Member
|
I believe this test should be expanded for explicit coverage of the Sepolia case (this is now somewhat hardcoded) Sepolia contract address: https://sepolia.etherscan.io/address/0x7f02c3e3c98b133055b8b348b2ac625669ed295d
Sepolia solidity source: https://github.com/protolambda/testnet-dep-contract/blob/master/deposit_contract.sol Sepolia create deposit contract tx: https://sepolia.etherscan.io/tx/0x025ecbf81a2f1220da6285d1701dc89fb5a956b62562ee922e1a9efd73eb4b14 (this has the deployment code which is necessary for the storage setup. Cannot use mainnet defaults because need to also setup the ERC20 token balance). For this, I believe the only state diff with mainnet prestate is this: This inits I believe if you use the raw data of above's tx then it should give the sender the For test cases, these things come to mind:
For reference this is the deployment bytecode of the sepolia deposit contract as taken from https://sepolia.etherscan.io/tx/0x025ecbf81a2f1220da6285d1701dc89fb5a956b62562ee922e1a9efd73eb4b14: |
d7c1e49 to
a397684
Compare
|
have you tried generating the test locally? |
8 tasks
13 tasks
Member
Author
|
Superseded by #1371 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Creates a test that replaces the mainnet contract with the Sepolia variant.
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.