feat(types,specs,tests): Verify resulting transaction receipt#1068
Merged
feat(types,specs,tests): Verify resulting transaction receipt#1068
Conversation
912d281 to
bad166b
Compare
winsvega
suggested changes
Jan 10, 2025
winsvega
left a comment
There was a problem hiding this comment.
lots of comments.
I think I found a bug because the transaction exception was verified in all cases and now it is inside If
af61efc to
6493b33
Compare
8 tasks
6493b33 to
472b064
Compare
472b064 to
df7dfc9
Compare
winsvega
approved these changes
Jan 15, 2025
winsvega
left a comment
There was a problem hiding this comment.
add a unit test for transaction exception verification
4 cases (well if none vs none is already covered)
docs: Add snipet about receipts changelog fixup: specs Co-authored-by: winsvega <dimitry@ethereum.org>
df7dfc9 to
09b3688
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Transaction.expected_receiptAdds
expected_receiptto theTransactionclass in order to signal the test specs that the resulting receipt returned by the transition tool must be verified against the expected values.At the moment only
gas_usedis compared, since this is the only value returned by execution-specs, but this is also the value most used by tests.Updated tests:
Following gas-related tests have been updated in this PR to incorporate a transaction gas usage test:
🔗 Related Issues
#402
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.