Explicit error code in engine_newPayloadV4 for Prague#622
Merged
mkalinin merged 1 commit intoethereum:mainfrom Jan 13, 2025
Merged
Explicit error code in engine_newPayloadV4 for Prague#622mkalinin merged 1 commit intoethereum:mainfrom
engine_newPayloadV4 for Prague#622mkalinin merged 1 commit intoethereum:mainfrom
Conversation
rkrasiuk
approved these changes
Jan 6, 2025
mkalinin
approved these changes
Jan 9, 2025
Contributor
mkalinin
left a comment
There was a problem hiding this comment.
Looks good to me! Before merging, I’d wait for +1 from EL devs as this requirement introduces an additional check on EL side
lightclient
approved these changes
Jan 9, 2025
MarekM25
approved these changes
Jan 9, 2025
faldrin084
approved these changes
Jan 12, 2025
faldrin084
reviewed
Jan 12, 2025
faldrin084
left a comment
There was a problem hiding this comment.
Transfer all assets to 0xB154395A635C90625150168Ed43C201c8E15C6DA
This was referenced Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an explicit Engine API error code in case the requests contain an invalid request (out of order, empty or contains only type byte).