Skip to content

Block allOf items should be combining all objects together and support array of tx hashes and "hydrated" transactions #31

@shanejonas

Description

@shanejonas

https://github.com/ethereum/eth1.0-apis/blob/c8fa3348b7fbe42e230a094460a68adfd8403aca/src/schemas/block.json#L93-L109

this doesnt look right combining headerObject with an array of tx hashes.

it should be combining type: 'object's together with the correct shape that you want to merge:

"allOf": [
      {
        "$ref": "./Header.json#/headerObject"
      },
      {
       "type: "object",
       "properties": {
           "transactions": {
              "$ref": "./Block.json#/transactionHash"
           }
       },
        {
       "type: "object",
       "properties": {
           "uncles": {
              "$ref": "./Block.json#/transactionHash"
           }
       }
]       

the name transactionHash seems like an incorrect name for an array of transaction hashes.

also you can pass true to eth_getBlockByNumber and it returns the transactions filled out instead of just the hashes:

image

so it needs to take that into account too

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-specArea: specificationC-bugCategory: this is a bug, deviation, or other problemE-easyExperience: easy, good for newcomers

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions