Add test for proposer lookahead excluding exited validators#4380
Merged
leolara merged 1 commit intoJun 13, 2025
Merged
Conversation
leolara
approved these changes
Jun 13, 2025
Member
|
I think you can merge @linoscope or you don't have the rights? |
Member
Thanks for merging. And nope, only the people in this team can merge PRs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests that check that the proposer lookahead excludes exited validators.
I tried doing the same for activation (i.e., proposer lookahead for epoch
N+1can contain proposers that were activated inN), but it turned out a lot more complicated. But think this test should be sufficient to test that the proposer lookahead takes the proper active validator set into consideration.