You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds test coverage for the mock Engine API interface methods in NoopExecutionEngine across multiple forks (Bellatrix, Deneb, Electra). The tests verify that each fork's implementation maintains its specific interface contract while providing mock behaviors for CL-EL interaction in test scenarios.
The Engine API interface has evolved across forks:
The reason I'm asking for this is because these directories (block_processing, fork, fork_choice, etc) are associated with a test format (see formats) which are exported and run by clients. unittests is the exception here, this directory contains tests which are not exported.
The reason I'm asking for this is because these directories (block_processing, fork, fork_choice, etc) are associated with a test format (see formats) which are exported and run by clients. unittests is the exception here, this directory contains tests which are not exported.
Thank you for your review! I have moved the tests to the respective forks' unittests directory. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for the mock Engine API interface methods in
NoopExecutionEngineacross multiple forks (Bellatrix, Deneb, Electra). The tests verify that each fork's implementation maintains its specific interface contract while providing mock behaviors for CL-EL interaction in test scenarios.The Engine API interface has evolved across forks:
Add fork-specific test files:
Improves coverage by 5 SLoC in CL-EL mock implementation, with proper fork-specific interface testing.