Skip to content

[Tests] Add test cases for partially withdrawable validator scenarios#4094

Merged
jtraglia merged 2 commits into
ethereum:devfrom
bshastry:add-eip7251-test
Jan 27, 2025
Merged

[Tests] Add test cases for partially withdrawable validator scenarios#4094
jtraglia merged 2 commits into
ethereum:devfrom
bshastry:add-eip7251-test

Conversation

@bshastry

Copy link
Copy Markdown
Contributor

Add test cases to verify partial withdrawal eligibility across different validator types and balance thresholds as specified in EIP-7251.

Test scenarios:

  • Compounding validators (0x02) at and around MAX_EFFECTIVE_BALANCE_ELECTRA
  • Legacy validators (0x01) at and around MAX_EFFECTIVE_BALANCE

@jtraglia jtraglia mentioned this pull request Jan 22, 2025
4 tasks

@mkalinin mkalinin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jtraglia

Copy link
Copy Markdown
Member

I've chatted with @bshastry some privately & there are some changes we'd like to make.

I will save this PR for the next release, the beta.2 release.

@bshastry

Copy link
Copy Markdown
Contributor Author

@jtraglia Thanks, I've incorporated your feedback. Looks ready for another round of review/merge.

@jtraglia jtraglia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @bshastry!

@jtraglia jtraglia merged commit 294db63 into ethereum:dev Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants