Add test with multiple deposit requests with same pubkey but different withdrawal credentials#4085
Merged
Merged
Conversation
…drawal credentials
…nt withdrawal credentials
mkalinin
reviewed
Jan 20, 2025
jtraglia
approved these changes
Jan 20, 2025
jtraglia
left a comment
Member
There was a problem hiding this comment.
This is really great, thank you! 😄
I pushed two small commits to help readability; notably a check which tells the reader that the top-up withdrawal credentials are indeed different.
This was referenced Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test which checks that the withdrawal credentials associated with the same pubkey are retained, rather than being made the same. It randomly picks 2 deposit requests and their pubkeys are made the same as the top deposit.
fixes partially: #4054