Skip to content

Fix block hash computation for fork transition tests#4022

Merged
hwwhww merged 1 commit into
ethereum:devfrom
etan-status:ef-blockhashfix
Nov 28, 2024
Merged

Fix block hash computation for fork transition tests#4022
hwwhww merged 1 commit into
ethereum:devfrom
etan-status:ef-blockhashfix

Conversation

@etan-status

Copy link
Copy Markdown
Contributor

When overriding execution_requests, have to sync EL payload block hash as the requests are linked to it. Note that this was only caught now because the new request tests were added after the latest fixes applied.

When overriding `execution_requests`, have to sync EL payload block hash
as the requests are linked to it. Note that this was only caught now
because the new request tests were added after the latest fixes applied.

@hwwhww hwwhww left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hwwhww hwwhww added the testing CI, actions, tests, testing infra label Nov 28, 2024
@hwwhww hwwhww merged commit 493d97e into ethereum:dev Nov 28, 2024
@etan-status etan-status deleted the ef-blockhashfix branch November 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants