Skip to content

Updated validator spec with rules for including execution requests in the beacon block body#3976

Merged
jtraglia merged 14 commits into
ethereum:devfrom
lucassaldanha:update-validator-electra
Oct 11, 2024
Merged

Updated validator spec with rules for including execution requests in the beacon block body#3976
jtraglia merged 14 commits into
ethereum:devfrom
lucassaldanha:update-validator-electra

Conversation

@lucassaldanha

@lucassaldanha lucassaldanha commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Defined/Updated ssz_serialize and ssz_deserialize functions
  • Updated GetPayloadResponse with execution_requests: Sequence[bytes]
  • Updated get_payload definition with extra detail re execution_requests
  • New section in "Constructing the BeaconBlockBody for ExecutionRequests"
  • Updated list[bytes] to Sequence[bytes]

@lucassaldanha

lucassaldanha commented Oct 9, 2024

Copy link
Copy Markdown
Contributor Author

cc @mkalinin

gfukushima
gfukushima reviewed Oct 9, 2024
View reviewed changes
Comment thread specs/electra/validator.md Outdated
Comment thread specs/electra/validator.md Outdated
mkalinin
mkalinin reviewed Oct 10, 2024
View reviewed changes
Comment thread specs/electra/validator.md Outdated
@mkalinin mkalinin mentioned this pull request Oct 10, 2024
Open
@lucassaldanha lucassaldanha marked this pull request as ready for review October 10, 2024 04:27
mkalinin
mkalinin reviewed Oct 10, 2024
View reviewed changes
Comment thread tests/core/pyspec/eth2spec/utils/ssz/ssz_impl.py Outdated
@ensi321 ensi321 mentioned this pull request Oct 10, 2024
Merged
ensi321
ensi321 reviewed Oct 10, 2024
View reviewed changes
Comment thread specs/electra/validator.md Outdated
twoeths
twoeths reviewed Oct 10, 2024
View reviewed changes
Comment thread specs/electra/validator.md Outdated
@lucassaldanha

lucassaldanha commented Oct 10, 2024

Copy link
Copy Markdown
Contributor Author

@hwwhww could you help me understand the test failures? 😢

@jtraglia

jtraglia commented Oct 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@hwwhww could you help me understand the test failures? 😢

I think I know the reason. List is a remerkleable type and requires a max length component. For example:

List[DepositRequest, MAX_DEPOSIT_REQUESTS_PER_PAYLOAD]

And in this PR we use List without a length in the updated GetPayloadResponse type. Instead, we can use Sequence which does not require a max length component. I'll push a commit for this.

hwwhww
hwwhww reviewed Oct 10, 2024
View reviewed changes

@hwwhww hwwhww left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems @jtraglia has solved the linter issue? (🙏)

Comment thread tests/core/pyspec/eth2spec/utils/ssz/ssz_impl.py
ralexstokes
ralexstokes reviewed Oct 10, 2024
View reviewed changes
Comment thread specs/electra/validator.md Outdated
ralexstokes
ralexstokes reviewed Oct 10, 2024
View reviewed changes
Comment thread specs/electra/validator.md Outdated
jtraglia and others added 3 commits October 10, 2024 13:29
@jtraglia @ralexstokes
Clarify execution requests return
f9ae4c5 
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
@jtraglia @ralexstokes
Capitalize SSZ
83c04b8 
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
@jtraglia
Add ssz_{de,}serialize aliases
6416a56
hwwhww
hwwhww approved these changes Oct 11, 2024
View reviewed changes

@hwwhww hwwhww left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you @lucassaldanha!

@jtraglia jtraglia merged commit a2e16c8 into ethereum:dev Oct 11, 2024
@lucassaldanha lucassaldanha deleted the update-validator-electra branch October 11, 2024 21:17
@johncrosschimezie

johncrosschimezie commented Dec 14, 2024

Copy link
Copy Markdown

✌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nflaig nflaig nflaig left review comments

@mkalinin mkalinin mkalinin approved these changes

@hwwhww hwwhww hwwhww approved these changes

@jtraglia jtraglia jtraglia approved these changes

+5 more reviewers

@ralexstokes ralexstokes ralexstokes left review comments

@twoeths twoeths twoeths left review comments

@ensi321 ensi321 ensi321 left review comments

@gfukushima gfukushima gfukushima left review comments

@Godstimendako Godstimendako Godstimendako left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

electra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.