Conversation
djrtwo
reviewed
Apr 8, 2021
| # Mock fictitious justified checkpoint in store | ||
| store.justified_checkpoint = spec.Checkpoint( | ||
| epoch=spec.compute_epoch_at_slot(last_signed_block.message.slot), | ||
| root=spec.Root("0x4a55535449464945440000000000000000000000000000000000000000000000") |
Contributor
There was a problem hiding this comment.
why not use htr of last_block_root for justified_checkpoint.root?
Contributor
Author
There was a problem hiding this comment.
We want to trigger this piece of code from should_update_justified_checkpoint:
if not get_ancestor(store, new_justified_checkpoint.root, justified_slot) == store.justified_checkpoint.root:
return FalseIf we use last_block_root & spec.compute_epoch_at_slot(last_signed_block.message.slot) to construct store.justified_checkpoint, then the newly constructed blocks will not trigger this, and should_update_justified_checkpoint returns True because the new justified checkpoint is a descendant of the current one in the store.
Contributor
Author
There was a problem hiding this comment.
Filling in a fictitious root ensures that this get_ancestor check fails and should_update_justified_checkpoint returns False, creating the test scenario we want
djrtwo
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2298