Attestation reward bug#1682
Merged
Merged
Conversation
Contributor
|
Splitting up that rewards function in the spec would be great for testing. All rewards mixed together in one function obfuscate what is really happening. Our mistake for not catching this bug earlier during release, but a good motivation for de-obfuscating this function. |
protolambda
approved these changes
Mar 24, 2020
protolambda
left a comment
Contributor
There was a problem hiding this comment.
Thanks @michaelsproul
hwwhww
approved these changes
Mar 24, 2020
9 tasks
This was referenced Apr 10, 2020
Member
|
Can we have a link to the tests for this fix? (probably would have helped avoid issues like Consensys/teku#1703) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[replaces #1680]
Bug found by @michaelsproul in rewards calculations introduced in
v0.11.0.PR to
v011xfor immediate release