Skip to content

Normalize attestation signature getter name#1671

Merged
djrtwo merged 2 commits into
v011xfrom
val-attestation-sig
Mar 20, 2020
Merged

Normalize attestation signature getter name#1671
djrtwo merged 2 commits into
v011xfrom
val-attestation-sig

Conversation

@djrtwo

@djrtwo djrtwo commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

Supersedes #1670

@hwwhww hwwhww left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnetheduck

Copy link
Copy Markdown
Contributor

fwiw, in the code we ended up with a bunch of these get_*_signature - they work with minimal information though and not the full state - effectively, we don't want to send the whole state across to the validator, so we pick the specific data:

https://github.com/status-im/nim-beacon-chain/blob/a7963b0b8c9113466dc4dabce62a193b00d228f0/beacon_chain/spec/state_transition_block.nim#L485

@djrtwo

djrtwo commented Mar 20, 2020

Copy link
Copy Markdown
Contributor Author

The decision to pass the state around around most times was to reduce the size of crazy function signatures (some that would have 8+ args). That decision rippled through the entire codebase for better or worse.

Much respect for your functions

@djrtwo djrtwo merged commit 6fde75b into v011x Mar 20, 2020
@djrtwo djrtwo deleted the val-attestation-sig branch March 20, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants