add DoS prevention validation conditions to additional gossipsub topics#1617
Merged
Conversation
…slashing, and attester_slashing gossipsub channels
djrtwo
commented
Feb 12, 2020
| - The proposer slashing is the first valid proposer slashing received for the proposer with index `proposer_slashing.index`. | ||
| - All of the conditions within `process_proposer_slashing` pass validation. | ||
| - `attester_slashing` - This topic is used solely for propagating attester slashings to proposers on the network. Attester slashings are sent in their entirety. Clients who receive an attester slashing on this topic MUST validate the conditions within `process_attester_slashing` before forwarding it across the network. | ||
| - At least one index in the intersection of the attesting indices of each attestation has not yet been seen in any prior `attester_slashing` (i.e. `any((set(attestation_1.attesting_indices).intersection(attestation_2.attesting_indices)).difference(prior_seen_attester_slashed_indices))`). |
Contributor
Author
There was a problem hiding this comment.
Open to suggestions on making the code snippet more readable
protolambda
reviewed
Feb 13, 2020
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
Contributor
Author
|
Addressed your comment @protolambda |
This was referenced Mar 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add DoS prevention validation conditions to voluntary_exit, proposer_slashing, and attester_slashing gossipsub channels.
For each, only gossip the message if have not yet seen a prior valid message of that type for the relevant validator(s)
[also clarify in some other conditions that the no-repeat clause is only for valid messages]