drop head_block_root from BeaconBlocksByRange#1604
Merged
Conversation
4505010 to
bc832d4
Compare
This change simplifies the protocol and removes a race condition between block request and response. In the case of honest server, this helps serve the canonical / fork-chosen chain better while dishonest or broken servers still need to be handled the same way. Might as well get started on versions and upgrade it to 2, since the change is backwards incompatible.
bc832d4 to
c943b58
Compare
Contributor
|
This was discussed and agreed upon by all those on the lastest networking call. Specifically in addition to @arnetheduck (Nimbus), @AgeManning (lighthouse) agreed that the head root does not really help and in fact makes for coding some tough edge cases. Leaving this PR open until Monday for any additional input from other client teams |
Contributor
|
LGTM, we haven't been using this field anyway in Prysm |
Member
|
+1 |
1 similar comment
Contributor
|
+1 |
djrtwo
reviewed
Feb 4, 2020
djrtwo
left a comment
Contributor
There was a problem hiding this comment.
Two tiny comments before merge
Contributor
|
+1 |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies the protocol and removes a race condition between
block request and response. In the case of honest server, this helps
serve the canonical / fork-chosen chain better while dishonest or broken
servers still need to be handled the same way.
Might as well get started on versions and upgrade it to 2, since thechange is backwards incompatible.