Output original opcode instead of PUSHC/JUMPC/JUMPCI in VM trace#5852
Output original opcode instead of PUSHC/JUMPC/JUMPCI in VM trace#5852
Conversation
| - Fixed: [#5821](https://github.com/ethereum/aleth/pull/5821) `test_setChainParams` correctly initializes custom configuration of precompiled contracts. | ||
| - Fixed: [#5826](https://github.com/ethereum/aleth/pull/5826) Fix blocking bug in database rebuild functionality - users can now rebuild their databases via Aleth's '-R' switch. | ||
| - Fixed: [#5827](https://github.com/ethereum/aleth/pull/5827) Detect database upgrades and automatically rebuild the database when they occur. | ||
| - Fixed: [#5834](https://github.com/ethereum/aleth/pull/5834) Fix segmentation fault during sync. |
There was a problem hiding this comment.
Removed this entry, as it's already mentioned in 1.7.2
Codecov Report
@@ Coverage Diff @@
## master #5852 +/- ##
==========================================
+ Coverage 64.06% 64.08% +0.01%
==========================================
Files 362 362
Lines 30898 30900 +2
Branches 3432 3432
==========================================
+ Hits 19796 19802 +6
+ Misses 9874 9871 -3
+ Partials 1228 1227 -1 |
chfast
left a comment
There was a problem hiding this comment.
Does this resolve to no-op in case there is no tracing callback?
libevm/LegacyVM.cpp
Outdated
| { | ||
| #if EVM_REPLACE_CONST_JUMP | ||
| ON_OP(); | ||
| onOperation(Instruction::JUMPC); |
There was a problem hiding this comment.
| onOperation(Instruction::JUMPC); | |
| onOperation(Instruction::JUMPI); |
3d88a34 to
514539a
Compare
@chfast Yes, in case callback is not set There's other definition for Lines 68 to 73 in bdc7674 |
Fixes #5847
cc @holiman