This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Revert "wait for 2 seconds on disconnect" changes#5841
Merged
gumb0 merged 5 commits intorelease/1.7from Nov 22, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.7 #5841 +/- ##
===============================================
+ Coverage 63.8% 63.81% +0.01%
===============================================
Files 358 358
Lines 30595 30598 +3
Branches 3406 3406
===============================================
+ Hits 19520 19525 +5
- Misses 9846 9847 +1
+ Partials 1229 1226 -3 |
Member
|
I think we shouldn't modify 1.7.0 changelog, as it's already released, so I added an entry about revert to 1.7.2 instead |
gumb0
approved these changes
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes were causing frequent exceptions during syncing (see #5835, #5828) due to
Host::m_sessions andEthereumPeer::m_peersgetting out-of-sync (if a peer reconnects during a pending disconnect), so we are reverting the changes in the 1.7 release until we can properly address the sync issues.