This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Fix database rebuild functionality#5826
Merged
halfalicious merged 3 commits intomasterfrom Nov 15, 2019
Merged
Conversation
b72fa49 to
b462489
Compare
One can now initiate a rebuild via -R and have it complete successfully, whereas prior to these changes it would fail with a database corruption error.
Also insert the genesis block details into the extras database during rebuild since the genesis block won't be reimported during the rebuild process.
2cf00c1 to
f8b1362
Compare
Codecov Report
@@ Coverage Diff @@
## master #5826 +/- ##
==========================================
- Coverage 64.09% 64.08% -0.02%
==========================================
Files 360 360
Lines 30876 30893 +17
Branches 3428 3426 -2
==========================================
+ Hits 19791 19798 +7
- Misses 9854 9865 +11
+ Partials 1231 1230 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5823
One can now initiate a rebuild via
-Rand have it complete successfully, whereas prior to these changes it would fail with a database corruption error. The problem was that importing the first block would fail because it required the genesis block details, which weren't re-inserted into them_detailscache after it was cleared in preparation for rebuild.