Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Upgrade EVMC to version 7.0.0#5810

Merged
chfast merged 2 commits intorelease/1.7from
evmc7
Nov 12, 2019
Merged

Upgrade EVMC to version 7.0.0#5810
chfast merged 2 commits intorelease/1.7from
evmc7

Conversation

@chfast
Copy link
Copy Markdown
Member

@chfast chfast commented Nov 6, 2019

Questions:

  • Is aleth-interpreter still being tested?
  • Are we running any CHAINID tests?

@chfast chfast requested review from gumb0 and halfalicious November 6, 2019 21:55
@gumb0
Copy link
Copy Markdown
Member

gumb0 commented Nov 7, 2019

Is aleth-interpreter still being tested?

Yes, but here it fails to load

#!/bin/bash -eo pipefail
ETHEREUM_TEST_PATH=~/project/test/jsontests \
test/testeth -t GeneralStateTests -- --vm libaleth-interpreter/libaleth-interpreter.so
terminate called after throwing an instance of 'boost::wrapexcept<std::system_error>'
  what():  loading lib*****-interpreter/lib*****-interpreter.so failed: EVMC create function not found: Illegal seek
Received 'aborted' signal

Are we running any CHAINID tests?

Yes, there're GeneralStateTests/stChainId and BCGeneralStateTests/stChainId
Also a couple of unit tests.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #5810 into release/1.7 will decrease coverage by <.01%.
The diff coverage is 51.51%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.7    #5810      +/-   ##
===============================================
- Coverage        63.83%   63.83%   -0.01%     
===============================================
  Files              358      358              
  Lines            30602    30596       -6     
  Branches          3406     3406              
===============================================
- Hits             19536    19531       -5     
+ Misses            9837     9836       -1     
  Partials          1229     1229

@chfast
Copy link
Copy Markdown
Member Author

chfast commented Nov 8, 2019

Yes, but here it fails to load

This is related to the change: ipsilon/evmc#440

gumb0
gumb0 previously approved these changes Nov 8, 2019
View reviewed changes
@chfast chfast marked this pull request as ready for review November 12, 2019 12:02
@chfast chfast merged commit db5bd0b into release/1.7 Nov 12, 2019
@chfast chfast deleted the evmc7 branch November 12, 2019 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@halfalicious halfalicious Awaiting requested review from halfalicious

1 more reviewer

@gumb0 gumb0 gumb0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chfast @gumb0 @codecov-io