This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Optimize SELFDESTRUCT opcode in LegacyVM#5807
Merged
halfalicious merged 2 commits intomasterfrom Nov 5, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5807 +/- ##
=========================================
Coverage ? 64.06%
=========================================
Files ? 359
Lines ? 30783
Branches ? 3418
=========================================
Hits ? 19720
Misses ? 9837
Partials ? 1226 |
008b37b to
d294fc2
Compare
d294fc2 to
37a0524
Compare
gumb0
approved these changes
Nov 5, 2019
Member
gumb0
left a comment
There was a problem hiding this comment.
Will need rebase in changelog, please keep Added-Changed-Removed-Fixed order
37a0524 to
a1c2b91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if transaction has enough gas to fund base gas cost for SELFDESTRUCT opcode before checking Ethereum state