Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Add Berlin hardfork support to Aleth#5754

Closed
halfalicious wants to merge 2 commits intomasterfrom
add-berlin-support
Closed

Add Berlin hardfork support to Aleth#5754
halfalicious wants to merge 2 commits intomasterfrom
add-berlin-support

Conversation

@halfalicious
Copy link
Copy Markdown
Contributor

@halfalicious halfalicious commented Sep 22, 2019

Added the LegacyVM schedule and made other edits so that the Berlin hardfork option is available.

@halfalicious halfalicious requested review from chfast and gumb0 and removed request for gumb0 September 22, 2019 21:34
@halfalicious
Copy link
Copy Markdown
Contributor Author

halfalicious commented Sep 22, 2019

@gumb0 / @chfast Do I also need to add Berlin test entries to the Network enum:

aleth/libethashseal/GenesisInfo.h

Lines 29 to 83 in 7d82c60

/// The network id.
enum class Network
{
///< Normal Olympic chain.
// Olympic = 0,
/// Normal Frontier/Homestead/DAO/EIP150/EIP158/Byzantium/Constantinople chain.
MainNetwork = 1,
/// Normal Morden chain.
// Morden = 2,
/// New Ropsten Test Network
Ropsten = 3,
/// MainNetwork rules but without genesis accounts (for transaction tests).
MainNetworkTest = 69,
/// Normal Frontier/Homestead/DAO/EIP150/EIP158 chain without all the premine.
TransitionnetTest = 70,
/// Just test the Frontier-era characteristics "forever" (no Homestead portion).
FrontierTest = 71,
/// Just test the Homestead-era characteristics "forever" (no Frontier portion).
HomesteadTest = 72,
/// Homestead + EIP150 Rules active from block 0 For BlockchainTests
EIP150Test = 73,
/// Homestead + EIP150 + EIP158 Rules active from block 0
EIP158Test = 74,
/// EIP158Test + Byzantium active from block 0
ByzantiumTest = 75,
/// EIP158Test + Byzantium active from block 2
ByzantiumTransitionTest = 76,
/// Frontier rules + NoProof seal engine
FrontierNoProofTest = 77,
/// ByzantiumTest + Constantinople active from block 0
ConstantinopleTest = 78,
/// ConstantinopleTest + Experimental active from block 2
ExperimentalTransitionTest = 79,
/// MainNetwork rules without genesis accounts + NoProof seal engine
MainNetworkNoProofTest = 80,
/// Byzantium rules + NoProof seal engine
ByzantiumNoProofTest = 81,
/// Constantinople rules + NoProof seal engine
ConstantinopleNoProofTest = 82,
/// Byzantium + Constantinople + ConstantinopleFix active from block 0
ConstantinopleFixTest = 83,
/// Istanbul active from block 0
IstanbulTest = 84,
/// ConstantinopleFixTest + Istanbul active from block 2
IstanbulTransitionTest = 85,
// TransitionTest networks
FrontierToHomesteadAt5 = 100,
HomesteadToDaoAt5 = 101,
HomesteadToEIP150At5 = 102,
EIP158ToByzantiumAt5 = 103,
ByzantiumToConstantinopleFixAt5 = 104,
Special = 0xff ///< Something else.
};

@halfalicious halfalicious mentioned this pull request Sep 22, 2019
Merged
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7d82c60). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5754   +/-   ##
=========================================
  Coverage          ?   63.73%           
=========================================
  Files             ?      357           
  Lines             ?    30511           
  Branches          ?     3392           
=========================================
  Hits              ?    19447           
  Misses            ?     9838           
  Partials          ?     1226

@gumb0
Copy link
Copy Markdown
Member

gumb0 commented Sep 23, 2019

What's the difference from #5732 ?

@halfalicious
Copy link
Copy Markdown
Contributor Author

halfalicious commented Sep 23, 2019

What's the difference from #5732 ?

Ah I forgot about that PR, I’ll close this one

@halfalicious halfalicious deleted the add-berlin-support branch November 4, 2019 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chfast chfast Awaiting requested review from chfast

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@halfalicious @codecov-io @gumb0