Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

Coming to agreement with geth on RIPEMD touch revert - alternative solution#5663

Closed
gumb0 wants to merge 2 commits intomasterfrom
untouch-ripemd-alternative
Closed

Coming to agreement with geth on RIPEMD touch revert - alternative solution#5663
gumb0 wants to merge 2 commits intomasterfrom
untouch-ripemd-alternative

Conversation

@gumb0
Copy link
Copy Markdown
Member

@gumb0 gumb0 commented Jul 10, 2019

Alternative solution to #5652

@gumb0 gumb0 force-pushed the untouch-ripemd-alternative branch 2 times, most recently from c879b50 to dd42631 Compare July 10, 2019 09:35
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 10, 2019

Codecov Report

Merging #5663 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5663      +/-   ##
==========================================
+ Coverage      63%   63.03%   +0.02%     
==========================================
  Files         350      350              
  Lines       29905    29910       +5     
  Branches     3350     3351       +1     
==========================================
+ Hits        18843    18854      +11     
+ Misses       9846     9842       -4     
+ Partials     1216     1214       -2

@gumb0 gumb0 force-pushed the untouch-ripemd-alternative branch from dd42631 to 8665d20 Compare July 10, 2019 09:36
…ree with geth.

Now precompile stays touch even after revert in the calling frame, but only for one RIPEMD precompile.
@gumb0 gumb0 force-pushed the untouch-ripemd-alternative branch from 8665d20 to e5b92d8 Compare July 10, 2019 09:37
@gumb0
Copy link
Copy Markdown
Member Author

gumb0 commented Jul 11, 2019

Closing in favor of #5664

@gumb0 gumb0 closed this Jul 11, 2019
@gumb0 gumb0 deleted the untouch-ripemd-alternative branch July 11, 2019 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants