This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Removed PARANOID build option (#5631)#5655
Merged
chfast merged 3 commits intoethereum:masterfrom Jul 9, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5655 +/- ##
=========================================
+ Coverage 62.79% 62.8% +<.01%
=========================================
Files 349 348 -1
Lines 29722 29707 -15
Branches 3346 3345 -1
=========================================
- Hits 18665 18657 -8
+ Misses 9845 9838 -7
Partials 1212 1212 |
chfast
suggested changes
Jul 8, 2019
libdevcore/OverlayDB.cpp
Outdated
| void OverlayDB::kill(h256 const& _h) | ||
| { | ||
| #if ETH_PARANOIA || 1 | ||
| #if 1 |
Contributor
Author
There was a problem hiding this comment.
Sure thing, just removed the block
Member
There was a problem hiding this comment.
Actually, you should not. Leave the #if 1 block and remove the #else one.
Contributor
Author
There was a problem hiding this comment.
Sorry, oversight on my part - just changed it.
chfast
approved these changes
Jul 8, 2019
Member
|
Are you able to squash 2 last commits? |
c1dba47 to
4417642
Compare
Contributor
Author
Should now be squashed 👍 |
Member
|
Ok, great. I will merge it as soon the Windows build finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5631 - Remove PARANOID build and
#define ETH_PARANOIA